Open sebhrusen opened 4 years ago
Sounds good 👍 but I would make the creation and activation of the virtual environment optional. I disagree that the default behavior of the install should be to create a new venv in which to install rather than installing it in the active venv.
I disagree that the default behavior of the install should be to create a new venv in which to install rather than installing it in the active venv.
I agree with you, not sure what I had in mind when writing this: it doesn't make sense to systematically create a venv on install.
The main idea is to have a simpler, one liner, way to set up the app. but I'm not sure it's currently doable using pip install
/setup.py
as the app is writing under frameworks
folder each time the user is using a different framework, and more importantly it would completely prevent the container mode due to limitations with docker context root.
Currently virtual envs appear in various places:
README
recommends users to create their own virtual env underautomlbenchmark
.docker
andaws
images create a virtual env for the app under/venvs/bench
.frameworks/shared/setup.sh
offers the possibility to create a virtual env underframeworks/{framework}/venv
dedicated to the framework for a better isolation.The last one should stay as is. However we could standardize the first 2 by creating a
setup.py
that would automatically create and activate a local virtual environment underautomlbenchmark/venv
+ install dependencies, and use this setup script indocker
+aws
setup.Library should then be ready to use after simply running:
pip install .