search

openml / openml-python

Python module to interface with OpenML
https://openml.github.io/openml-python/main/
Other
279 stars 143 forks source link

Add more type annotations #1261

Closed mfeurer closed 9 months ago

mfeurer commented 1 year ago

This PR add type annotations for the remaining files in openml namespace.

codecov-commenter commented 1 year ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3b5ba6a) 82.62% compared to head (7234c85) 82.59%.

Files Patch % Lines
openml/cli.py 0.00% 4 Missing :warning:
openml/base.py 72.72% 3 Missing :warning:
openml/config.py 93.54% 2 Missing :warning:
openml/testing.py 83.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1261 +/- ## =========================================== - Coverage 82.62% 82.59% -0.03% =========================================== Files 38 38 Lines 5116 5120 +4 =========================================== + Hits 4227 4229 +2 - Misses 889 891 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LennartPurucker commented 9 months ago

The tests are now failing (they did not previously) due to server state. As far as I can tell, this is not related to the PR itself, and I will merge it now to prepare for the hackathon next week (where we will hopefully fix the tests).