search

openml / openml-python

Python module to interface with OpenML
https://openml.github.io/openml-python/main/
Other
279 stars 143 forks source link

[Contributing] Mentions `string.format`, are f-strings allowed? #1295

Open eddiebergman opened 9 months ago

eddiebergman commented 9 months ago

Hiyo,

Just reading the contributing guide and in the sections it mentions about the pep8 guidelines, it doesn't mention f-strings. I would imagine these are allowed and we should add a section to CONTRIBUTING.md?

PGijsbers commented 9 months ago

F-strings are the preferred way to format strings since a few years, but we didn't go an change old-style formatting unless a PR affected them. Might be useful to just run something like flynt (no experience using it) to convert all strings.