openml / openml-python

Python module to interface with OpenML
https://openml.github.io/openml-python/main/
Other
276 stars 142 forks source link

Linting Everything - Fix All mypy and ruff Errors #1307

Closed LennartPurucker closed 6 months ago

LennartPurucker commented 6 months ago

Closes: #716, #1297, #876, #1301, #1299, #1002

Rel.: #1255, #1283

This PR finalizes our transition to ruff and mypy. As a result, all public classes and functions will be typed and documented.

Co-authored by: @Bilgecelik @eddiebergman @LennartPurucker

codecov-commenter commented 6 months ago

Codecov Report

Attention: 233 lines in your changes are missing coverage. Please review.

Comparison is base (43c66aa) 79.35% compared to head (e38fdd1) 59.79%. Report is 2 commits behind head on develop.

:exclamation: Current head e38fdd1 differs from pull request most recent head 10a2f5e. Consider uploading reports for the commit 10a2f5e to get more accurate results

Files Patch % Lines
openml/datasets/dataset.py 51.28% 57 Missing :warning:
openml/runs/functions.py 40.35% 34 Missing :warning:
openml/runs/trace.py 50.00% 24 Missing :warning:
openml/evaluations/functions.py 37.03% 17 Missing :warning:
openml/setups/functions.py 61.53% 15 Missing :warning:
openml/tasks/task.py 62.85% 13 Missing :warning:
openml/datasets/functions.py 73.91% 12 Missing :warning:
openml/utils.py 64.70% 12 Missing :warning:
openml/_api_calls.py 79.62% 11 Missing :warning:
openml/runs/run.py 47.61% 11 Missing :warning:
... and 7 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1307 +/- ## ============================================ - Coverage 79.35% 59.79% -19.57% ============================================ Files 38 38 Lines 5076 5168 +92 ============================================ - Hits 4028 3090 -938 - Misses 1048 2078 +1030 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.