openml / openml-python

Python module to interface with OpenML
https://openml.github.io/openml-python/main/
Other
276 stars 142 forks source link

Superseded by pre-commit.ci #1343

Closed PGijsbers closed 2 weeks ago

PGijsbers commented 2 weeks ago

No longer needed since we have pre-commit.ci active. I suppose the latter only works on the delta and not all files, but that should not be an issue.

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.82%. Comparing base (e4e6f50) to head (a38022e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1343 +/- ## =========================================== - Coverage 83.88% 83.82% -0.06% =========================================== Files 38 38 Lines 5261 5261 =========================================== - Hits 4413 4410 -3 - Misses 848 851 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eddiebergman commented 2 weeks ago

I've never used the standalone github plugin. Looks pretty good in terms of speed, probably better than a naive setup through github actions. Fire ahead!

One caveat to consider is that if you ever want to consider pre-commit as a requirement before a release, i.e. in an automated fashion, you may need to re-introduce that it runs through github actions somewhere

PGijsbers commented 2 weeks ago

It's definitely faster, often finishes before the GHA job is even set up. I do think the concern is valid, but I think that would be clearer to do that in whatever dedicated release pipeline we build and not as a standalone workflow anyway.