Closed PGijsbers closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.82%. Comparing base (
e4e6f50
) to head (a38022e
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I've never used the standalone github plugin. Looks pretty good in terms of speed, probably better than a naive setup through github actions. Fire ahead!
One caveat to consider is that if you ever want to consider pre-commit
as a requirement before a release, i.e. in an automated fashion, you may need to re-introduce that it runs through github actions somewhere
It's definitely faster, often finishes before the GHA job is even set up. I do think the concern is valid, but I think that would be clearer to do that in whatever dedicated release pipeline we build and not as a standalone workflow anyway.
No longer needed since we have pre-commit.ci active. I suppose the latter only works on the delta and not all files, but that should not be an issue.