search

openml / server-api

Python-based server
https://openml.github.io/server-api/
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Moved PHP docker to the PHP repository #143

Closed josvandervelde closed 1 week ago

josvandervelde commented 9 months ago

See https://github.com/openml/OpenML/pull/1212.

For the https://github.com/openml/services/tree/feature/docker-compose, I've chosen to use elasticsearch 6.8.23 (same as production) for now.

I've updated openml/php-rest-api docker container to work with ES6. This is problematic for this server-api repo. A simple solution could be to create openml/php-rest-api:es8. What do you think?

PGijsbers commented 9 months ago

I think that's fine. Would also need to update the docker-compose.

PGijsbers commented 1 week ago

I think downgrading ES should accomplish the same thing? There is still a minor issue of some ES errors, but those exists before the downgrade too. Only when a tag is pushed for a dataset which already had tag(s)... but it's possible this happens in production too. I'll see if it reproduces or if it's a work item for this resource.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@19bab14). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #143 +/- ## ======================================= Coverage ? 91.93% ======================================= Files ? 49 Lines ? 1823 Branches ? 144 ======================================= Hits ? 1676 Misses ? 105 Partials ? 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PGijsbers commented 1 week ago

Doesn't reproduce for me. Doesn't even reproduce locally for me right now, but you can see it in CI (it's the SKIPS for the tag).