search

openmm / openmm-cookbook

The OpenMM Cookbook and Tutorials
38 stars 10 forks source link

Turn off PR gh-actions deployment? #37

Open sef43 opened 9 months ago

sef43 commented 9 months ago

Currently when a PR is made a gh-actions workflow tries to build and deploy the PR onto the gh-pages branch so it can be viewed. However, this only works correctly if the PR is made from a branch within the openmm/openmm-cookbook repo. It does not work from any personal forks of the cookbook. This is a github permissions issue which I do not think can be worked around.

As personal forks and PRing is the typical contribution method this gh-actions workflow becomes rather pointless and confusing by throwing workflow errors whenever someone makes a PR.

We could remove it. Or maybe make it only run if the PR comes from within the repo?

peastman commented 9 months ago

How about removing it for PRs, but still running it on the main branch after it is merged?