openmm / openmm-plumed

OpenMM plugin to interface with PLUMED
55 stars 23 forks source link

Update the build system and fix CI #68

Open raimis opened 1 year ago

raimis commented 1 year ago
raimis commented 1 year ago

@peastman I cannot revive the MacOS tests. The is an issue with OpenCL tests and I cannot fix it. Any ideas about how to fix?

peastman commented 1 year ago

We shouldn't be installing pocl on Mac. There's no need, since OpenCL is built into the OS. The first thing I'd try is removing it.

raimis commented 1 year ago

@peastman I have remove pocl for MacOS, but now the OpenCL test fail because

exception: No compatible OpenCL platform is available
peastman commented 1 year ago

Do you know what kind of GPU the runner has? Perhaps it's configured in a way that prevents it from accessing the GPU?

When running OpenMM CI builds on Mac, we build the OpenCL platform but don't run any tests for it. I don't remember why. Possibly it was for the same reason?

raimis commented 1 year ago

I have disabled the OpenCL test on MacOS. I have no experience with MacOS to fix that.

raimis commented 1 year ago

@peastman could you review?

peastman commented 1 year ago

With OpenMM plugins, we generally don't want to pin the builds to a particular OpenMM version. Every release of the plugin is designed to work with one particular OpenMM release. We don't try to maintain compatibility with older releases, which often isn't possible. And if a new OpenMM release breaks compatibility, we want CI builds of the plugin to start failing immediately so we know we need to update it.

raimis commented 1 year ago

Ideally, we should build tests against the night builds (if ones still exist) of OpenMM. If we notice an incompatibility after the next OpenMM release, it is a bit too late.