search

openmm / openmm-xtb

OpenMM plugin to interface with XTB
MIT License
10 stars 1 forks source link

Enable CI #2

Closed peastman closed 9 months ago

peastman commented 9 months ago

What else do I need to do to enable CI? The docs claim just putting a .yml file in .github/workflows is enough. But it's saying CI hasn't been set up.

cc @mikemhenry @RaulPPelaez

mikemhenry commented 9 months ago

I think the issue is that this PR targets main but the triggers for the yaml file is master as the target

peastman commented 9 months ago

I committed your changes, but it still says, "Continuous integration has not been set up."

mikemhenry commented 9 months ago

We might just need to merge it in and see if it goes, since this PR is coming in from a fork, github might have things setup that if a file gets added to CI, it has to exist in the repository first so that random people can't open PRs and burn CI minutes? I would just merge it in and see what happens.

peastman commented 9 months ago

so that random people can't open PRs and burn CI minutes?

It's already set so first time contributors need to be approved before CI runs. But ok, let's try and see what happens.

peastman commented 9 months ago

Sure enough, it seems to be running. Shrug? Thanks!