Open rmcgibbo opened 9 years ago
+1
Also, would there be a correction applied to the manuscript (if the scaling is indeed critical)?
I think the scaling is just an optimization that absorbs some constants into the variable holding the inverse jacobian, but I'm not sure exactly how it all comes together.
@peastman and I spent some time looking at the CCMA code today, as part of trying to build a new test case. The code is kind of hard to follow mathematically, and doesn't really track exactly with the paper.
apply()
function, the construction of the error term looks looks like it's a kind of squared relative error, but in the paper it's an absolute error (not relative) and also not squared. OTOH, the construction of the jacobian tracks the paper very closely (e.g. eq. 4 and this code) This makes it a little tricky to figure out what's going on during the newton-raphson iterations.The code is overall pretty ancient, I think. It would be nice to refresh it and add some documentation.