Updated swig wrappers. - Githubissues

openmm / openmmexampleplugin

An example of how to write a plugin for OpenMM

30 stars 22 forks source link

Updated swig wrappers. #9

Closed jlmaccal closed 10 years ago

jlmaccal commented 10 years ago

Wrappers now include:

Support for STL vectors.
Automatic removal of units
Automatic conversion of numpy arrays to lists
Addition of units to output parameters
Proper handling of OUTPUT reference parameters

peastman commented 10 years ago

You don't need to reproduce stripUnits() here. It's already a public member of simtk.openmm, so you can just call it directly.

jlmaccal commented 10 years ago

OK, fixed.

peastman commented 10 years ago

I think these lines probably got copied over by accident:

%pythonappend OpenMM::Context::Context %{
 self._system = args[0]
 self._integrator = args[1]
%}

Also, shouldn't there be an "import simtk.unit as unit" in there somewhere? I didn't see one, yet you refer to members of the unit module. Does it actually work as written?

jlmaccal commented 10 years ago

Yes on both counts. Fixed.

peastman commented 10 years ago

Thanks!