search

openmm / pdbfixer

PDBFixer fixes problems in PDB files
Other
453 stars 114 forks source link

See our manual link broken #212

Closed birbilis closed 3 years ago

birbilis commented 3 years ago

At the bottom of the pdbfixer repo page it says "See our manual" but when you follow the link there's some issue saying "TypeError: Failed to fetch" (the url is http://htmlpreview.github.io/?https://raw.github.com/pandegroup/pdbfixer/master/Manual.html )

giadefa commented 3 years ago

@jchodera this is still broken

peastman commented 3 years ago

Apparently this is a problem in htmlpreview: https://github.com/htmlpreview/htmlpreview.github.com/issues/95. I posted about it a couple of weeks ago but haven't received any response. I'll try again.

TrianguloY commented 3 years ago

Copied from the htmlpreview repo: the link is wrong, should be https://htmlpreview.github.io/?https://github.com/openmm/pdbfixer/blob/master/Manual.html (or https://htmlpreview.github.io/?https://github.com/pandegroup/pdbfixer/blob/master/Manual.html )

Edit: created pull request for convenience

peastman commented 3 years ago

I just tried both those links, and both of them still give the same error for me.

TrianguloY commented 3 years ago

Really? Can someone else try? Here is what I see: imagen

peastman commented 3 years ago

Very strange! It fails for me in Firefox, but I just tried Safari and that works. I thought maybe it had cached the bad version, but I tried clearing the cache in Firefox and it still fails.

peastman commented 3 years ago

Never mind: it was NoScript getting in the wey.

birbilis commented 3 years ago

note that page also points to the currently broken omnia.md url

TrianguloY commented 3 years ago

@birbilis I'm not a member of this repo, so it's probably better to wait for an official reply, but my recommendation is to create a new issue for the broken omnia.md problem (its not related to this one) and, if you know of an alternate link, suggest it or even create a pull request with the change (like I did here).

peastman commented 3 years ago

The URL is correct, but that page is currently down.

birbilis commented 3 years ago

had mentioned it at https://github.com/openmm/openmm/issues/2896, hope they manage to grab that domain name back, else don't know in how many places they'll need to fix it (there is another url mentioned there that could be used: https://omniamd.squarespace.com/ )