openmm / pdbfixer

PDBFixer fixes problems in PDB files
Other
443 stars 112 forks source link

pypi version #254

Open Pantelispanka opened 1 year ago

Pantelispanka commented 1 year ago

Will there ever be a pypi package for the module ? If you are planning for that i can offer some help! Thanks!

peastman commented 1 year ago

I hope so! We first need PyPI packages for OpenMM, which PDBFixer depends on. We're investigating that right now: https://github.com/openmm/openmm/issues/3796. If you want to help, that would be fantastic.

minhuanli commented 1 year ago

Hi, I want to do a quick follow up on this issue.

Why don't we make PDBFixer a PyPI package alone? The main OpenMM module seems tricky because of the cuda stuff, but you could assume people have already installed the OpenMM before they need PDBFixer? Just save people from downloading the whole repo before installation.

peastman commented 1 year ago

What would be the use case for that? If you've already installed OpenMM with conda, what's the benefit of installing PDBFixer with pip instead of conda?

minhuanli commented 1 year ago

I am not sure if I take it correctly. Do you mean PDBFixer itself can be installed by conda? I didn't see that in the installation tutorials

minhuanli commented 1 year ago

One common case for me is that, I have installed OpenMM according to the official document:

conda install -c conda-forge openmm cudatoolkit=xx.x

Then I realize that I also need PDBfixer to preprocess PDB files.

It would be great if I could simply do pip install PDBFixer instead of git clone the whole repo and run pip install .

peastman commented 1 year ago

Correct. This will install it, including all dependencies.

conda install -c conda-forge pdbfixer

We should add that to the README.

minhuanli commented 1 year ago

Got it! That makes much more sense now. Yes, should add this to the README. Thank you for the clarification.

peastman commented 1 year ago

The updated instructions are in #265.

recursingfeynman commented 8 months ago

If pdbfixer were on pypi it would be convenient to install it along with dependencies via poetry. Poetry can also handle dependencies like conda, but unlike it it shows better performance