openmobilehub / omh-maps

omh-maps
Apache License 2.0
3 stars 1 forks source link

Remove unnecessary fields under application in the getting started guide #62

Closed dzuluaga closed 1 year ago

dzuluaga commented 1 year ago

The current getting started guide for setting up an Android application includes unnecessary fields under the <application> tag in the AndroidManifest.xml file. These additional fields might confuse users and cause issues when they don't find the expected values or encounter conflicts with existing resources.

Suggested Improvement: Instead of specifying all the fields, it would be clearer and less error-prone to only instruct users to add the application class to the AndroidManifest.xml file.

Proposed Manifest Code:

<application
    android:name=".DemoApp">
</application>

This modification ensures that users correctly define the application class without any unnecessary or potentially conflicting fields.

Additionally, it would be helpful to provide a clarification in the documentation, indicating that users should replace .DemoApp with the actual name of their application class. This would prevent any confusion or assumptions about the specific name to use.

Please let me know if there are any further details or specific requirements I should include in the GitHub bug report.

CC - @prestonlau @rquino

hans-hamel commented 1 year ago

Maybe we can keep like this:

<application
        android:name=".DemoApp"
        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:theme="@style/Theme.OMHMaps">
dzuluaga commented 1 year ago

LGTM. Thx