openmobilehub / omh-maps

omh-maps
Apache License 2.0
3 stars 1 forks source link

Property "omhProviderBuilder" is never used #69

Closed dzuluaga closed 1 year ago

dzuluaga commented 1 year ago

What is the purpose of omhProviderBuilder member variable? onCreate initializes a local variable instead. If it's not needed, pls remove it.

class DemoApp : Application() {

    var omhProviderBuilder: OmhMapProvider.Builder? = null

    override fun onCreate() {
        super.onCreate()

        val omhProviderBuilder = OmhMapProvider.Builder()
        omhProviderBuilder
            .addGmsPath(BuildConfig.MAPS_GMS_PATH)
            .addNonGmsPath(BuildConfig.MAPS_NON_GMS_PATH)
        initialize(omhProviderBuilder)
    }
}
hans-hamel commented 1 year ago

Refactor like this:

override fun onCreate() {
        super.onCreate()

        val omhProviderBuilder = OmhMapProvider.Builder()
            .addGmsPath(BuildConfig.MAPS_GMS_PATH)
            .addNonGmsPath(BuildConfig.MAPS_NON_GMS_PATH)
        OmhMapSDK.initialize(omhProviderBuilder)
    }
dzuluaga commented 1 year ago

LGTM. Thx