Sample App: Clarification with Getting started steps + current location not working on non GMS

openmobilehub / omh-maps

omh-maps

Apache License 2.0

3 stars 2 forks source link

Sample App: Clarification with Getting started steps + current location not working on non GMS #80

Closed itsme291 closed 1 year ago

itsme291 commented 1 year ago

It is not clear whether a user needs to download Sample app or take any specific action with sample App.
Explain that user can switch build variance to be able to run the app on GMS and non GMS device
Highlight the benefit that you can use a single build for GMS and non GMS without changes to the code
In my testing, on non GMS device (Huawei Huawei P40 Pro, Model ELS-NX9, Android version 10) the maps did not pick my current location (the phone did not have a sim card)

@dzuluaga

dzuluaga commented 1 year ago

@nelsonwilches @hans-hamel - Can you guys take a look at this feedback? Thanks!

dzuluaga commented 1 year ago

@hans-hamel @nelsonwilches Similar feedback impacting the Getting Started. Please address these issues. This urgent for meeting acceptance testing. SAMP001.

CC - @prestonlau @rquino

hans-hamel commented 1 year ago

Sure took in consideration and added in the branch https://github.com/openmobilehub/omh-maps/tree/release/1.0