openmobilehub / omh-storage

omh-storage
Apache License 2.0
7 stars 2 forks source link

Missing local.properties Step in GitHub Actions Workflows #127

Closed dzuluaga closed 1 year ago

dzuluaga commented 1 year ago

GitHub Actions workflows for OMH Storage API, OMH Storage API Drive GMS Implementation, and OMH Storage API Drive non-GMS Implementation are failing due to the absence of the local.properties setup step in the workflow YAML files. This step is essential for configuring environment variables and SDK paths.

Proposed Solution:

Add the necessary step to set up the local.properties file in the workflow YAML files to resolve the build failures.

Reference Run: GitHub Actions Run

Please address this issue promptly to enable successful builds and contributions. Feel free to reach out for any additional information.

HectorNarvaez commented 1 year ago

You can check this with someone with knowledge in DevOps.

As Android developer, this is out of my scope.

c.c.: @nelsonwilches @dzuluaga @mariomonteroencora @teban1288

HectorNarvaez commented 1 year ago

I'll redirect this to @nelsonwilches for validate who will work on this

c.c.: @dzuluaga @teban1288 @mariomonteroencora

dzuluaga commented 1 year ago

It's a couple of line of code. Could you take a look at how the OMH Maps does it? Thanks

HectorNarvaez commented 1 year ago

Currently, github actions on storage are basically a copy-paste of the ones defined on auth and maps. The only difference is the one done due to issue #97 (PR #102)

Far away from that, i don't have knowledge about CI. So, @nelsonwilches will redirect this to an appropiate person.

c.c.: @dzuluaga @nelsonwilches @mariomonteroencora @teban1288

dzuluaga commented 1 year ago

Okay. But, for the record, you're already doing it on the on_pull_request.yml. It's just missing in the other yml files.

HectorNarvaez commented 1 year ago

Checked this with @hans-hamel and opened a PR: #130

Once merged, please let us know if this solves the issue

HectorNarvaez commented 1 year ago

PR merged

c.c.: @dzuluaga @nelsonwilches @mariomonteroencora @teban1288

dzuluaga commented 1 year ago

It works. Thanks!