search

openmobilehub / omh-storage

omh-storage
Apache License 2.0
7 stars 2 forks source link

Dialog is not displaying in `code-starter` branch sample #141

Closed dzuluaga closed 1 year ago

dzuluaga commented 1 year ago

I have noticed that the fixes that were applied to issue #98 in the release/1.0.0 branch do not seem to have been applied to the code-starter branch. For instance, I have found that the code in the FileViewerViewModel.kt file is missing in the code-starter branch. Please compare all the changes in release/1.0.0 branch and apply to code-starter branch and test the changes. As a result, the dialog is not displayed in the code-starter branch.

Additionally, I suggest making a minor change to the error message. Please update the message from Ups! Something went wrong to Something went wrong. This change should be applied consistently across both the release/1.0.0 and code-starter branches.

Let's ensure that the necessary fixes are applied to the code-starter branch and that the error message change is made accordingly to both branches. Thanks!

HectorNarvaez commented 1 year ago

Hello Diego

The code-starter branch actually is updated with branch release/1.0. Probably the snippets are the ones that are not updated so don't have the code for show the dialog. I'll take a look

HectorNarvaez commented 1 year ago

PR opened

HectorNarvaez commented 1 year ago

I validated that code-starter branch is updated with release/1.0. Also validated that the snippets are ok

HectorNarvaez commented 1 year ago

PR merged

dzuluaga commented 1 year ago

My bad. I missed updating the functions, which use the dialog.

That being said, I noticed the snippets in README out of sync. #145. Thanks for looking into it.