Align Environmental Variable Names Across React Native and Android Native

Hello Kacper,

I noticed a discrepancy in the naming conventions of environmental variables used in our React Native and Android Native projects. This inconsistency can lead to confusion for developers who work across these platforms. I propose aligning the naming conventions with those used in our Android Native project to maintain consistency and reduce potential errors.

Repositories Affected

React Native: react-native-omh-auth
Android Native: android-omh-auth

Current Naming Conventions

React Native

GOOGLE_CLIENT_ID=
FACEBOOK_APP_ID=
FACEBOOK_APP_SECRET=
MICROSOFT_CLIENT_ID=
DROPBOX_CLIENT_ID=
DROPBOX_CLIENT_SECRET=

Android Native

echo "GOOGLE_CLIENT_ID=$1" >> ./local.properties
echo "FACEBOOK_APP_ID=$2" >> ./local.properties
echo "FACEBOOK_CLIENT_TOKEN=$3" >> ./local.properties
echo "MICROSOFT_CLIENT_ID=$4" >> ./local.properties
echo "MICROSOFT_SIGNATURE_HASH=$5" >> ./local.properties
echo "DROPBOX_APP_KEY=$6" >> ./local.properties

Suggested Changes

Align the naming conventions in the React Native project with those used in the Android Native project:

Rename FACEBOOK_APP_SECRET to FACEBOOK_CLIENT_TOKEN in React Native to match Android Native.
Add MICROSOFT_SIGNATURE_HASH to React Native, if applicable.
Rename DROPBOX_CLIENT_ID and DROPBOX_CLIENT_SECRET in React Native to DROPBOX_APP_KEY to match the naming convention used in Android Native.

Expected Benefits

Consistency: Unifies naming conventions across platforms.
Clarity: Reduces confusion for developers switching between projects or those new to the projects.
Maintenance: Simplifies updates and maintenance related to environmental variables.

Next Steps

Awaiting feedback on this proposal from the team. If agreed, we will proceed with updating the environmental variables in the React Native project accordingly.

Thank you for considering this change to improve our project consistency.

Hey @dzuluaga, thanks for bringing this to our attention!

For React Native library we decided to stick with the following conventions: PROVIDER_CLIENT_ID & PROVIDER_CLIENT_SECRET. We believe this ensures that all providers follow a similar naming while also following the react-native-app-auth configuration. Moreover, we have added improvements in https://github.com/openmobilehub/react-native-omh-auth/pull/45/commits/c108c39e4534cba640819547b91c62c16f3e1f82 to the documentation of each provider to reflect their own naming conventions.

We have also corrected the .env.sample secrets for Facebook in https://github.com/openmobilehub/react-native-omh-auth/pull/45/commits/245383ffb5b7f79b7d44bcef670691a2b9bf9ba8.

openmobilehub / react-native-omh-auth