openmobilehub / react-native-omh-auth

https://openmobilehub.github.io/react-native-omh-auth/
Apache License 2.0
0 stars 0 forks source link

Unhandled Promise Rejection Error on Sign-In Page #40

Closed dzuluaga closed 1 month ago

dzuluaga commented 1 month ago

When attempting to sign in using any of the provided options (Google, Facebook, Microsoft, Dropbox) on the sample app, a JavaScript error message "Possible unhandled promise rejection" is repeatedly displayed. This issue occurs on the sign-in page, potentially impacting user experience by failing to provide actionable error information.

Steps to Reproduce

  1. Navigate to the sign-in page.
  2. Click on any of the sign-in options (Google, Facebook, Microsoft, Dropbox).
  3. Observe the error message at the bottom of the screen.

Expected Behavior

The sign-in should proceed without any errors, or a user-friendly error message should be displayed explaining the issue.

Actual Behavior

The error "Possible unhandled promise rejection" appears repeatedly, with no further information provided to the user.

Screenshot

image

Possible Solution

This issue might be related to unhandled promises within the sign-in function calls. It is recommended to ensure that all promises have appropriate catch() blocks to handle errors gracefully.

andrei-zgirvaci commented 1 month ago

Hey @dzuluaga, thanks for bringing this to our attention! This was addressed and should be fixed in https://github.com/openmobilehub/react-native-omh-auth/pull/45/commits/0e2857966c639226ef7ba795fca8e3d8514d7cf9.