Closed dzuluaga closed 1 month ago
Hey @dzuluaga, thanks for bringing this to our attention! This has been addressed and should be fixed in https://github.com/openmobilehub/react-native-omh-auth/pull/65/commits/487847a876dd8608fc06b6a2a93c98db30d2a632.
LGTM. Thanks, Andrei.
The contributing guide for the
react-native-omh-auth
repository is missing a crucial step for runningpod install
after setting up the project. This omission can lead to build failures when runningyarn start
oryarn workspace react-native-omh-auth-sample ios
.Steps to Reproduce:
react-native-omh-auth
repository.yarn start
oryarn workspace react-native-omh-auth-sample ios
.Actual Result: The build fails with errors such as:
Possible Solution: For newcomers, this step might be easy to miss but is essential for the build process. Add the following step to the contributing guide after running
yarn install
:ios
directory:pod install
to install the required CocoaPods dependencies:or
Note (optional in contributing.md): Ensure CocoaPods is installed. If you encounter
zsh: command not found: pod
, install CocoaPods using:Adding these instructions will prevent build errors due to missing CocoaPods dependencies and improve the onboarding experience for new contributors.
Thank you!
CC - @artus9033 in case this is also needed for maps.