openmobilehub / react-native-omh-maps

https://openmobilehub.github.io/react-native-omh-maps/
Apache License 2.0
22 stars 0 forks source link

Modules are referencing `@openmobilehub/maps-core@1.0.0-beta`, but this version doesn't exist [BLOCKING ISSUE WHILE USING OTHER MODULES] #101

Closed dzuluaga closed 2 weeks ago

dzuluaga commented 1 month ago

I encountered an issue while installing the @openmobilehub/maps-plugin-googlemaps and @openmobilehub/maps-plugin-openstreetmap packages. These modules have a peer dependency on @openmobilehub/maps-core@1.0.0-beta, but it seems that this version doesn't exist in the npm registry.

Steps to Reproduce:

  1. Run the following command in a project:
    npm install @openmobilehub/auth-google @openmobilehub/maps-plugin-googlemaps @openmobilehub/maps-plugin-openstreetmap
  2. The following warnings and errors are displayed:

    npm WARN Could not resolve dependency:
    npm WARN peer @openmobilehub/maps-core@"1.0.0-beta" from @openmobilehub/maps-plugin-googlemaps@1.0.0
    npm WARN node_modules/@openmobilehub/maps-plugin-googlemaps
    npm WARN   @openmobilehub/maps-plugin-googlemaps@"^1.0.0" from the root project
    
    npm ERR! code ETARGET
    npm ERR! notarget No matching version found for @openmobilehub/maps-core@1.0.0-beta.

Expected Behavior:

The installation should succeed without errors or warnings. The correct version of @openmobilehub/maps-core should be referenced by the plugins.

Actual Behavior:

The installation fails because @openmobilehub/maps-core@1.0.0-beta does not exist in the npm registry.

Additional Information:

Incorrect references:

Suggested Solution:

More context

Thank you for looking into this issue!

maciekBudzinski commented 1 month ago

Thank you for highlighting the issue. It seems to be fixed with the 1.0.2 release.

If you still struggle with some issues, make sure to follow the core instruction first and then plugins: google and openstreetmap.

I've also prepared the minimal sample that you can found here.

adamTrz commented 2 weeks ago

Hi @dzuluaga - closing the issue since it seems to have been resolved with lates release. In case of any issues still reappearing please reopen! 👍

dzuluaga commented 1 week ago

Yes, the issue was resolved after the modules were published. Moving forward, it would be great if we could avoid similar issues by having the team cross-test each other's work. This will help us catch any potential problems earlier.