search

openmobilehub / react-native-omh-maps

https://openmobilehub.github.io/react-native-omh-maps/
Apache License 2.0
23 stars 0 forks source link

Add Animations for OMH Maps React Native Sample App in README.md and Getting Started Docs #44

Closed dzuluaga closed 3 months ago

dzuluaga commented 4 months ago

Same case https://github.com/openmobilehub/react-native-omh-auth/issues/62. Thanks for your attention.

dzuluaga commented 3 months ago

@Nataliagros friendly ping. It's been open for a while and and these animations are crucial to understand the SDKs. Thanks.

Nataliagros commented 3 months ago

@dzuluaga we added this request to the current sprint and will deliver the animations soon. We would like to propose, however, to only focus on Maps view functionality and provide 6 GIFs instead of 48. It will save us a lot of time, help with maintainability, and should be sufficient for users of the library. Let me know what you think.

dzuluaga commented 3 months ago

I'm confused. 48 GIFs sounds like a huge list of videos. Why would maps require that many videos? We just want to showcase the functionality with GMS and non-GMS devices and showcase in the same video the sample app functionality. Thanks.

DamianNowak5f commented 3 months ago

@dzuluaga we would have to create 48 42 GIFs (I miscounted the functionalities and provided the wrong number to Natalia - apologies) if we wanted to maintain the same GIFs table that we have in the android-omh-maps.

There, we have a table made of four providers:

and seven functionalities:

So in total 28 GIFs.

For react-native-omh-maps we have additional two providers:

So If we wanted to create exact same table we would have to create GIFs for six providers and seven functionalities, resulting in 42 GIFs.

Our proposition is to create GIFs only for the Camera Map functionality - the first one that is shown in the android-omh-maps README. 

dzuluaga commented 3 months ago

Gotcha. Thanks for the explanation. Sounds good. 6 videos. But how instead of Camera Map functionality all the functionality? I understand the page will take longer to load because of the file sizes.

dzuluaga commented 3 months ago

One idea that @Nataliagros and I discussed on our last call was to record a single video in a single short (it doesn't need to be perfect). Then split this video into smaller ones after recording it. Will that make the job easier?

dzuluaga commented 3 months ago

Great. Thank you @DamianNowak5f and @Nataliagros.

CC - @prestonlau @itsme291