search

openmobilemaps / maps-core

The lightweight and modern Map SDK for Android and iOS
https://openmobilemaps.io
Mozilla Public License 2.0
162 stars 17 forks source link

Bugfix/rootless layers #654

Closed maerki closed 2 weeks ago

maerki commented 3 weeks ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes in this pull request introduce new methods to several classes related to map rendering and configuration, enhancing their interfaces. Specifically, getScalingFactor() is added to MapCameraInterface, and getVirtualZoomLevelInfos() is added to both Tiled2dMapLayerConfig and its derived classes. Additionally, several classes have been updated to improve buffer management and rendering processes, particularly in handling vertex data. Various formatting improvements and error handling enhancements have also been implemented across multiple files, contributing to better code readability and maintainability.

Changes

File Path Change Summary
bridging/android/java/io/openmobilemaps/mapscore/shared/map/MapCameraInterface.kt Added abstract method getScalingFactor() and implemented it in CppProxy.
bridging/android/java/io/openmobilemaps/mapscore/shared/map/layers/tiled/Tiled2dMapLayerConfig.kt Added abstract method getVirtualZoomLevelInfos() and implemented it in CppProxy.
bridging/android/jni/map/NativeMapCameraInterface.cpp Added native_getScalingFactor() method to retrieve scaling factor via JNI.
bridging/android/jni/map/layers/tiled/NativeTiled2dMapLayerConfig.cpp Added getVirtualZoomLevelInfos() method and corresponding JNI function.
bridging/android/jni/map/layers/tiled/NativeTiled2dMapLayerConfig.h Declared getVirtualZoomLevelInfos() method and added method ID for JNI.
bridging/ios/MCMapCameraInterface+Private.mm Added getScalingFactor() method to retrieve scaling factor from C++ interface.
bridging/ios/MCMapCameraInterface.h Declared getScalingFactor() method.
bridging/ios/MCTiled2dMapLayerConfig+Private.mm Added getVirtualZoomLevelInfos() method in Objective-C and C++ interfaces.
bridging/ios/MCTiled2dMapLayerConfig.h Declared getVirtualZoomLevelInfos() method in protocol.
djinni/map/core.djinni Added get_scaling_factor() method to map_camera_interface.
djinni/map/layers/tiled/tiled_layer.djinni Added get_virtual_zoom_level_infos() method to tiled_2d_map_layer_config.
ios/graphics/Model/BaseGraphicsObject.swift Updated buffer management and formatting in methods.
ios/graphics/Model/Icosahedron/Icosahedron.swift Modified rendering methods to use new buffer management.
ios/graphics/Model/Line/LineGroup2d.swift Enhanced buffer management and error handling in rendering methods.
ios/graphics/Model/MultiBuffer.swift Introduced MultiBuffer<DataType> structure for managing Metal buffers.
ios/graphics/Model/Polygon/Polygon2d.swift Updated rendering methods for improved buffer management.
ios/graphics/Model/Quad/Quad2d.swift Enhanced rendering capabilities and buffer management.
ios/graphics/Model/Quad/Quad2dInstanced.swift Updated buffer management and rendering logic.
ios/graphics/Model/Quad/Quad2dStretchedInstanced.swift Enhanced vertex and origin offset buffer management.
ios/graphics/Model/Text/Text.swift Improved vertex data management in rendering process.
ios/graphics/Model/Text/TextInstanced.swift Updated buffer handling and initialization process.
ios/graphics/RenderingContext.swift Added static property for buffer count and improved formatting.
ios/maps/MCMapView.swift Reformatted code and added semaphore for rendering management.
shared/public/MapCameraInterface.h Added virtual method getScalingFactor().
shared/public/Tiled2dMapLayerConfig.h Added virtual method getVirtualZoomLevelInfos().
shared/public/Tiled2dMapSource.h Various formatting adjustments and added new member variable topMostZoomLevel.
shared/public/Tiled2dMapSourceImpl.h Minor refactoring and formatting adjustments.
shared/public/Tiled2dMapVectorLayerConfig.h Added getVirtualZoomLevelInfos() method.
shared/src/map/camera/MapCamera3d.cpp Improved organization, added mutexes for thread safety, and updated method logic.
shared/src/map/camera/MapCamera3d.h Adjusted method signatures and added new member variables for thread safety.
shared/src/map/layers/tiled/Epsg4326Tiled2dMapLayerConfig.cpp Added getVirtualZoomLevelInfos() method.
shared/src/map/layers/tiled/Epsg4326Tiled2dMapLayerConfig.h Declared getVirtualZoomLevelInfos() method.
shared/src/map/layers/tiled/WebMercatorTiled2dMapLayerConfig.cpp Added getVirtualZoomLevelInfos() method.
shared/src/map/layers/tiled/WebMercatorTiled2dMapLayerConfig.h Declared getVirtualZoomLevelInfos() method.
shared/src/map/layers/tiled/vector/symbol/Tiled2dMapVectorSourceSymbolDataManager.cpp Updated scaling calculations and improved method implementations.
shared/src/map/layers/tiled/wmts/WmtsTiled2dMapLayerConfig.h Added getVirtualZoomLevelInfos() method returning an empty vector.

Poem

In the land of maps, where pixels play,
A scaling factor hops and sways.
Virtual zooms now dance in line,
With buffers managed, all is fine!
From camera to layer, changes abound,
In code's embrace, new joys are found! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.