search

openmobilemaps / maps-core

The lightweight and modern Map SDK for Android and iOS
https://openmobilemaps.io
Mozilla Public License 2.0
162 stars 17 forks source link

Bugfix/iconlayer 3d #655

Closed maerki closed 2 weeks ago

maerki commented 2 weeks ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces several enhancements across various classes and interfaces, primarily focusing on adding new methods for retrieving scaling factors and virtual zoom level information. Key additions include getScalingFactor() in the MapCameraInterface and getVirtualZoomLevelInfos() in multiple classes, enhancing their functionality without modifying existing methods. The changes also include the introduction of new classes, such as IconLayerObject, and significant updates to buffer management in graphics-related classes, improving performance and maintainability.

Changes

File Path Change Summary
bridging/android/java/io/openmobilemaps/mapscore/shared/map/MapCameraInterface.kt Added abstract fun getScalingFactor(): Double and its implementation in CppProxy.
bridging/android/java/io/openmobilemaps/mapscore/shared/map/layers/tiled/Tiled2dMapLayerConfig.kt Added abstract fun getVirtualZoomLevelInfos(): ArrayList<Tiled2dMapZoomLevelInfo> and its implementation in CppProxy.
bridging/android/jni/map/NativeMapCameraInterface.cpp Added native_1getScalingFactor method for JNI to retrieve scaling factor.
bridging/android/jni/map/layers/tiled/NativeTiled2dMapLayerConfig.cpp Added getVirtualZoomLevelInfos method for JNI to retrieve virtual zoom level information.
bridging/android/jni/map/layers/tiled/NativeTiled2dMapLayerConfig.h Added method declarations for getVirtualZoomLevelInfos().
bridging/ios/MCMapCameraInterface+Private.mm Added - (double)getScalingFactor for accessing the scaling factor.
bridging/ios/MCMapCameraInterface.h Added method declaration - (double)getScalingFactor;.
bridging/ios/MCTiled2dMapLayerConfig+Private.mm Added - (nonnull NSArray<MCTiled2dMapZoomLevelInfo *> *)getVirtualZoomLevelInfos method.
bridging/ios/MCTiled2dMapLayerConfig.h Added method declaration - (nonnull NSArray<MCTiled2dMapZoomLevelInfo *> *)getVirtualZoomLevelInfos;.
djinni/map/core.djinni Added get_scaling_factor() : f64; to map_camera_interface.
djinni/map/layers/tiled/tiled_layer.djinni Added get_virtual_zoom_level_infos() : list<tiled_2d_map_zoom_level_info; to tiled_2d_map_layer_config.
ios/graphics/Model/BaseGraphicsObject.swift Removed originOffsetBuffer, added originOffsetBuffers and vpMatrixBuffers, updated initializers and method signatures.
ios/graphics/Model/MultiBuffer.swift Introduced MultiBuffer<DataType> structure for managing multiple Metal buffers.
shared/public/IconLayerObject.h Added IconLayerObject class with various methods for managing icon layers.
shared/public/MapCameraInterface.h Added virtual method getScalingFactor().
shared/public/Tiled2dMapLayerConfig.h Added virtual method getVirtualZoomLevelInfos().
shared/src/map/layers/icon/IconLayer.cpp Updated methods to use IconLayerObject instead of Textured2dLayerObject.
shared/src/map/layers/tiled/Epsg4326Tiled2dMapLayerConfig.cpp Added getVirtualZoomLevelInfos() method for zoom level information.
shared/src/map/layers/tiled/WebMercatorTiled2dMapLayerConfig.cpp Added getVirtualZoomLevelInfos() method for virtual zoom levels.

Poem

🐇 In the land of code where changes bloom,
New methods sprout, dispelling gloom.
Scaling factors and zooms take flight,
Enhancing layers, making things right.
With buffers anew, our graphics gleam,
A rabbit's joy in this coding dream! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.