openmobilityfoundation / mobility-data-specification

A data standard to enable right-of-way regulation and two-way communication between mobility companies and local governments.
https://www.openmobilityfoundation.org/about-mds/
Other
685 stars 231 forks source link

Feature: Modes - Delivery #778

Closed tristan-charreton closed 2 years ago

tristan-charreton commented 2 years ago

Explain pull request

Work on deliveries to incorporate into Modes

Is this a breaking change

Impacted Spec

Which spec(s) will this pull request impact?

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

schnuerle commented 2 years ago

@tristan-charreton Can you make sure the 'Allow Edits by Maintainers' checkbox in your pull request? That will allow me to clean up some of your work to align to other parts of the modes work. See if you can edit the PR and check it. If not, you will have to delete this PR then recreate with a new PR.

See bottom of this screenshot:

Screen Shot 2022-09-08 at 3 26 13 PM
tristan-charreton commented 2 years ago

Closing this PR before recreating it to allow maintainers to edit.

tristan-charreton commented 2 years ago

Hello @schnuerle I reopen the PR as even when creating a new PR, I do not find the "allow edits by maintainers" checkbox. Checkbox

schnuerle commented 2 years ago

@tristan-charreton I'm not sure why this isn't showing up for you, sorry! It has happened before. I think it's due to permissions/settings on the source organization/repo/branch on GitHub, in this case https://github.com/kiwibot-data/mobility-data-specification/tree/feature-modes-delivery

I know it would work if you took that Kiwibot branch and cloned it to your own account, then used that branch to make the pull request.