openmobilityfoundation / mobility-data-specification

A data standard to enable right-of-way regulation and two-way communication between mobility companies and local governments.
https://www.openmobilityfoundation.org/about-mds/
Other
676 stars 232 forks source link

Remove 'rate' rule-type, since we can put rate_amount on any rule #806

Closed marie-x closed 1 year ago

marie-x commented 1 year ago

MDS Pull Request

Explain pull request

Removing the rate rule-type from Policy, as the notion of rate_amount etc. is available on all other rule-types.

Is this a breaking change

Impacted Spec

Which spec(s) will this pull request impact?

Additional context

Addresses #662, #674, and #704

schnuerle commented 1 year ago

Could you see how this PR relates to the following issues, if at all? #662 #663 #704

jean-populus commented 1 year ago

Thanks for doing this @marie-x ! I think you caught everything on my list wrt rates. Wondering if you wanted to also update the Policy Examples at the same time?

marie-x commented 1 year ago

Addresses #662 and #704 but not #663

marie-x commented 1 year ago

Thanks for doing this @marie-x ! I think you caught everything on my list wrt rates. Wondering if you wanted to also update the Policy Examples at the same time?

Yes! I should definitely do that.

schnuerle commented 1 year ago

I think once the conflicts are resolved we can merge this to dev, @marie-x. The schemas are less important as we will be moving to OpenAPI for 2.0.

schnuerle commented 1 year ago

@jean-populus could you resolve the conflicts with the policy examples please?

jean-populus commented 1 year ago

Yes, will try to do that this week.