openmobilityfoundation / mobility-data-specification

A data standard to enable right-of-way regulation and two-way communication between mobility companies and local governments.
https://www.openmobilityfoundation.org/about-mds/
Other
676 stars 232 forks source link

Stop.rental_methods vs. fare_attributes.payment_type #844

Closed thekaveman closed 1 year ago

thekaveman commented 1 year ago

Issue

Stops defines the rental_methods field as follows:

Enum[]: List of payment methods accepted at stop, see GBFS Rental Methods

GBFS Rental Methods as of April 2023 are:

Further, some modes support the fare_attributes.payment_type field, with a different list of options and the the following variation:

care-share delivery-robots passenger-services
cash x x x
credit_card x x
mobile x x x
voucher x x x
paratransit x x
no payment x x x
test x x x
schnuerle commented 1 year ago

Stops may be a bit of an outlier right now and should just stay aligned with GBFS and reference that externally.

For the modes, I think 1) paratransit needs to be removed from delivery robots, 2) credit_card added to delivery robots.

applepay vs androidpay is too specific a field for us in MDS land I think. But account_number and phone could be added to all modes, and then maybe mobile needs to be called mobile_app for clarity?

What are the values for micromobility?

thekaveman commented 1 year ago

What are the values for micromobility?

The micromobility mode does not use the fare_attributes property of trip: https://github.com/openmobilityfoundation/mobility-data-specification/blob/release-2.0.0/modes/micromobility.md#fare-attributes

Stops may be a bit of an outlier right now and should just stay aligned with GBFS and reference that externally.

Roger 👍 In https://github.com/openmobilityfoundation/mds-openapi/pull/5 I updated the casing to match exactly with GBFS.

For the modes, I think 1) paratransit needs to be removed from delivery robots, 2) credit_card added to delivery robots.

Done in https://github.com/openmobilityfoundation/mds-openapi/pull/5

But account_number and phone could be added to all modes, and then maybe mobile needs to be called mobile_app for clarity?

Happy to do this as well.

thekaveman commented 1 year ago

@schnuerle in thinking about adding phone and changing mobile to mobile_app... It still doesn't seem clear to me, how does phone differ from mobile_app?

schnuerle commented 1 year ago

Phone is when a reservation is made via a phone call, to a phone number. So it's different from a mobile app.

schnuerle commented 1 year ago

Payment types are aligned in this commit. Ready to close this issue when confirmed by @thekaveman.

thekaveman commented 1 year ago

Looks good 👍