search

openmobilityfoundation / mobility-data-specification

A data standard to enable right-of-way regulation and two-way communication between mobility companies and local governments.
https://www.openmobilityfoundation.org/about-mds/
Other
676 stars 232 forks source link

MDS 2.0 - telemetry fields trip_ids/journey_id should correspond to the event #859

Closed lastalfriday closed 1 year ago

lastalfriday commented 1 year ago

Extracted from another issue here

EDIT I'm a bit confused. I just noticed that there are some differences between the tag 2.0.0-rc1 and the branch release-2.0.0. So I'm splitting this issue into 1 and 2, as they are related (instead of making another issue)

1 - Which is right

https://github.com/openmobilityfoundation/mobility-data-specification/blob/release-2.0.0/data-types.md#events (I'm guessing this is right, but why was journey_id removed? If it's relevant for telemetry, is it not relevant for events?)

image

https://github.com/openmobilityfoundation/mobility-data-specification/blob/2.0.0-rc1/data-types.md#events

image

2 - Telemetry fields that should be optional

The fields trip_ids and journey_id should be the same for telemetry and events, and I do believe events has it correct (these fields must be required if available and optional)

This diff/error is probably a cut n paste error?

image

marie-x commented 1 year ago

Good catch! Yes, they should be consistent. I think the wording in Telemetry conveys the intent better.

thekaveman commented 1 year ago

@lastalfriday The branch release-2.0.0 should be the base for any issues/review for MDS 2.0 as it is being updated continuously until the release.

The tag 2.0.0-rc1 was made back in Feb as part of the MDS Release Process.