search

openmobilityfoundation / mobility-data-specification

A data standard to enable right-of-way regulation and two-way communication between mobility companies and local governments.
https://www.openmobilityfoundation.org/about-mds/
Other
676 stars 232 forks source link

Add MyWheels #901

Closed wbohlken closed 2 months ago

wbohlken commented 2 months ago

name: Default about: Suggest changes to MDS title:

MDS Pull Request

Thank you for your contribution! Please review our OMF contributing page to understand guidelines and policies for participation, and our Code of Conduct page.

To avoid complications and help make the Review process as smooth as possible, make sure to:

  1. Target dev branch. Please ensure you are targeting dev, not main.
  2. Keep the "Allow edits from maintainers" button checked to help us resolve some issues for you.
  3. Be ready to resolve any merge conflicts before we approve your Pull Request.
  4. Have an up to date profile, per our Github community profile guildance.

Explain pull request

Please provide a clear and concise reason for this pull request and the impact of the change

Is this a breaking change

A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).

Impacted Spec

Which spec(s) will this pull request impact?

Additional context

Add any other context or screenshots about the feature request here.

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: schnuerle
:x: Wouter Bohlken

Wouter Bohlken seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

schnuerle commented 2 months ago

Looks good @wbohlken! Make sure to sign this digital license agreement then I can merge your changes to dev.

wbohlken commented 2 months ago

Hi @schnuerle, thanks for the review. I signed the agreement, can this be merged?

schnuerle commented 2 months ago

Hi @wbohlken GitHub is still showing me the license agreement is not signed yet. Could you try again here? Here's what I'm seeing:

image
wbohlken commented 2 months ago

Hi @schnuerle , that's odd, I signed it multiple times. Just did it again, does it work now?

schnuerle commented 2 months ago

Not sure what went wrong, but I went ahead and made the same edit myself with #902, so we can close this issue and you are all set. Thank you!

wbohlken commented 2 months ago

Hi @schnuerle, perfect, thank you!