search

openmobilityfoundation / mobility-data-specification

A data standard to enable right-of-way regulation and two-way communication between mobility companies and local governments.
https://www.openmobilityfoundation.org/about-mds/
Other
683 stars 231 forks source link

Include `trip_stop` Event in Trip ID Requirements Documentation #917

Open hynick4 opened 1 month ago

hynick4 commented 1 month ago

Is your feature request related to a problem? Please describe.

The documentation for Passenger Service and Car Share modes both define trip_stop as a valid Event Type, however the event is not listed under Trip ID Requirements as an event that requires a valid trip_id. The trip_stop event is directly related to Trip transitions, so should require a valid trip_id on the event.

Describe the solution you'd like

Add trip_stop as an event that requires a valid trip_id under Trip ID Requirements on Car Share and Passenger Services modes:

https://github.com/openmobilityfoundation/mobility-data-specification/blob/ec4f0107fad8e03b48d3d5ef1ac65e2e41a89b44/modes/car-share.md?plain=1#L63

https://github.com/openmobilityfoundation/mobility-data-specification/blob/ec4f0107fad8e03b48d3d5ef1ac65e2e41a89b44/modes/passenger-services.md?plain=1#L66

Is this a breaking change

Impacted Spec

schnuerle commented 2 weeks ago

Great thank you and thanks for the catch! We will update in MDS 2.0. If you'd like to be a contributor, you may open a pull request to suggest the details of this change. If not the community can do it at a later date.