search

openmodelingfoundation / openmodelingfoundation.github.io

Website for standards and governance of the Open Modeling Foundation
https://openmodelingfoundation.org
Creative Commons Zero v1.0 Universal
52 stars 34 forks source link

Show sub-pages in sidebar navigation when top-level page is selected #428

Closed mlange-42 closed 2 years ago

mlange-42 commented 2 years ago

It was bothering me a bit to have to scroll down to the list of sub-pages. Only when on a subpage, sibling pages appear in the sidebar navigation.

Modified the nav sidebar layout to include sub-pages when on a top-level page.

Screenshot of the sidebar when on the About page, before the change:

grafik

After the change:

grafik

cmbarton commented 2 years ago

This bothered me too. I took a quick look and realized it was a bit more complicated to change than I thought because the hot links at the bottom are on a separate page somehow. How did you deal with them?

mlange-42 commented 2 years ago

Didn't touch the links at the bottom. Also not sure why they should be related to the nav bar, technically? It probably does not hurt to leave them in place, so readers can't miss the sub-sections. Despite the redundancies.

alee commented 2 years ago

Thanks for the PR @mlange-42 ! This is a clear improvement but it exposes a larger problem - apparently we are still using docsy theme code from v0.1.0 of docsy and should upgrade to the latest release, v0.4.0 which has numerous improvements and changes but also breaks some of the ways we were extending / modifying the theme. Here's what it looks like with the latest v0.4.0 sidebar-tree template:

image

I think it might be worth the time to invest upgrading to the latest version of docsy to resolve this issue as well as the others and can continue to push those changes to this branch. Thoughts?

cmbarton commented 2 years ago

I agree about updating to a better looking and more flexible web overlay. Any idea how much will break if we upgrade? With the recent papers, it would be a very good time for the site to be looking and working better--and at the same time not so good a time for it to be broken.

mlange-42 commented 2 years ago

Please don't care for this PR while updating. It is a very quick fix. Probably the functionality I added here is already there in v0.4.0. At least in another project using Docsy, I got it out of the box.

Generally, I think updating it a good thing. The longer you wait, the more breaking changes.

mlange-42 commented 2 years ago

I agree about updating to a better looking and more flexible web overlay. Any idea how much will break if we upgrade? With the recent papers, it would be a very good time for the site to be looking and working better--and at the same time not so good a time for it to be broken.

Should not be a problem to fix it on a branch, and merge into develop when not broken anymore.

alee commented 2 years ago

The PR already exists and explains the issue well so if you don't mind keeping the fork/branch open I'll add the changes here and lay the changes on top :sweat_smile:

Please don't care for this PR while updating. It is a very quick fix. Probably the functionality I added here is already there in v0.4.0. At least in another project using Docsy, I got it out of the box.

Generally, I think updating it a good thing. The longer you wait, the more breaking changes.