openmopac / mopac

Molecular Orbital PACkage
http://openmopac.net
GNU Lesser General Public License v3.0
111 stars 31 forks source link

ci: update actions/checkout #200

Closed nbehrnd closed 4 months ago

nbehrnd commented 4 months ago

While using your yaml file as a template to set up a CI in a different repository, the previously used entry actions/checkout@v3 causes the suggestion to update to node (version 20). By [2024-10-23 Wed], this notification will then turn into a warning.(1)

So far, Ubuntu 22.04LTS this workflow uses allows the incremental update to actions/checkout@v4. Maybe the next Ubuntu LTS 24.04 (or its first point release) eventually provides version5 for GitHub actions, too.

(1): https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Status

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.75%. Comparing base (a22996f) to head (ed328ed).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #200 +/- ## ======================================= Coverage 66.75% 66.75% ======================================= Files 332 332 Lines 74082 74082 ======================================= Hits 49456 49456 Misses 24626 24626 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

godotalgorithm commented 4 months ago

Yes, I have noticed the node.js warnings recently. My hesitation in trying to fix them has been that some of the GitHub Actions that I'm using don't yet have versions that meet the new node requirements. It is probably a good practice to fix what can be fixed right now, so that there is less to deal with when this problem eventually escalates.

You fixed one instance of this problem. I'll add in the other corrections that are available right now before I accept this PR.

godotalgorithm commented 4 months ago

The only laggard is the jmarrec/setup-qtifw Action, which did upgrade to Node 16 last year, so presumably they will upgrade to Node 20 eventually.

nbehrnd commented 4 months ago

Only recently I recognized where GitHub actions can be useful for me; your example was the first practical one with enough parts understood well enough to successfully assemble one "locally". This is why I refrained myself to probe additional parts of your .yaml file for a potential modernization, and constrained the PR to be about an edit to this single line.

godotalgorithm commented 4 months ago

Not a problem, I appreciate the prod to fix this stuff, and you can't just blindly increase the version number of the Actions without checking for breaking changes.

I built MOPAC's GHA workflow from scratch mostly based on the very good documentation of GitHub Actions. It was a tedious and frustrating process, but the end result has been worthwhile.