search

openmove / journey

Openmove OpenTripPlanner UI
Other
4 stars 0 forks source link

Selecting start position on mobile reset open overlays #3

Open Ghoster981 opened 1 year ago

Ghoster981 commented 1 year ago

https://user-images.githubusercontent.com/33777471/220305612-6e07ac61-e1f6-407f-811b-137c7dbec2d2.mov

Ghoster981 commented 1 year ago

This is caused by the componentWillUnmount method of base-map. Due to how React elements are structured the BaseMap will unmount for each page change on mobile. In my opinion fix it would require to move the map component up in the component tree but doing so require to split in two the top and bottom parts of mobile pages, actually making the code hard to read.