Closed hadijahkyampeire closed 2 months ago
Size Change: +37.1 kB (+1%)
Total Size: 3.31 MB
Filename | Size | Change | |
---|---|---|---|
dist/225.js |
0 B | -515 kB (removed) | đ |
dist/794.js |
0 B | -114 kB (removed) | đ |
dist/86.js |
0 B | -34.4 kB (removed) | đ |
dist/0.js |
35.5 kB | +35.5 kB (new file) | đ |
dist/571.js |
114 kB | +114 kB (new file) | đ |
dist/582.js |
551 kB | +551 kB (new file) | đ |
@arodidev I have addressed the changes to move the JSON request in a hook, but for the autocomplete, I will handle it in another ticket.
Thoughts on this UI/UX?
@denniskigen I have updated the PR with the UI as suggested by Ciaran.
LGTM @hadijahkyampeire
@arodidev did you revert the approval?
@arodidev did you revert the approval?
No, I did not. Not sure how it got reverted.
@arodidev It says I reverted a stale review, not sure what that means.
@denniskigen I think this is now good to go in, please take another look.
@denniskigen This is the error I get when I try to extend IMarker
and the markers prop in the AceEditor gets flagged as well
Thanks @denniskigen
Requirements
Summary
inline notification
and paginates themRecording
https://github.com/openmrs/openmrs-esm-form-builder/assets/30952856/0452372d-8ceb-454e-8ec8-4a9a04147446
Related Issue