openmrs / openmrs-esm-form-builder

OpenMRS Form Builder microfrontend
Other
7 stars 70 forks source link

(feat) O3-3140: Add `patientIdentifier` question type with custom validator #264

Closed gitcliff closed 4 months ago

gitcliff commented 4 months ago

Requirements

Summary

This PR enables patientIdentifier to be added in the list of question types to be rendered when configuring questions

Screenshots

Screenshot 2024-05-08 at 1 53 36 AM

https://www.loom.com/share/b4dce4a2d2814e8598f593e5cb404b5f

Related Issue

https://openmrs.atlassian.net/browse/O3-3140

Other

denniskigen commented 4 months ago

Do patientIdentifer fields require a backing concept? If so, we should show a concept lookup field when adding the question similar to what's being done here.

gitcliff commented 4 months ago

what's being done here

Do patientIdentifer fields require a backing concept? If so, we should show a concept lookup field when adding the question similar to what's being done here.

Do patientIdentifer fields require a backing concept? If so, we should show a concept lookup field when adding the question similar to what's being done here.

@denniskigen Not really, since we are not capturing them as obs , the crucial bit is the PatientIdentifierType

gitcliff commented 4 months ago

helo @denniskigen ,,i have updated the PR

gitcliff commented 4 months ago

@denniskigen kindly review

denniskigen commented 4 months ago

Have you tested that the solution works as expected, @gitcliff?

gitcliff commented 4 months ago

Have you tested that the solution works as expected, @gitcliff?

yes @denniskigen i have tested https://www.loom.com/share/4d6d1888822c4682b6f9851b6213fe3d I will do a demo in the coffee break call