openmrs / openmrs-esm-form-builder

OpenMRS Form Builder microfrontend
Other
5 stars 55 forks source link

(feat) O3-3218: Make the schema validation(block/allow) render a configuration #271

Closed gitcliff closed 1 month ago

gitcliff commented 1 month ago

Requirements

Summary

This PR is addressing the issue enabling on and off schema validation via configuration, also during schema validation the user should be shown the validation errors but still be able to render and saving their changes

Screenshots

https://www.loom.com/share/cfc15777ebcf4cc6991110cd06a08638

Related Issue

Other

hadijahkyampeire commented 1 month ago

Thanks @gitcliff but I think we should always show the validation errors and highlights, the config should only be attached to the render, whether to allow rendering with errors or not. And the default should be false, then implementations that want to enforce validation will turn it true.

gitcliff commented 1 month ago

Thanks @gitcliff but I think we should always show the validation errors and highlights, the config should only be attached to the render, whether to allow rendering with errors or not. And the default should be false, then implementations that want to enforce validation will turn it true.

@hadijahkyampeire the validation errors and highlights are show when the user clicks render their changes . Default is false

hadijahkyampeire commented 1 month ago

So @gitcliff the thing is that the errors showing shouldn't depend on the config, we want to show errors and their highlights even if the config is false, the only thing the config should allow/block is the rendering part.