Closed denniskigen closed 1 month ago
Size Change: +3.98 kB (+0.12%)
Total Size: 3.46 MB
Filename | Size | Change | |
---|---|---|---|
dist/180.js |
0 B | -133 kB (removed) | π |
dist/24.js |
0 B | -35.5 kB (removed) | π |
dist/991.js |
0 B | -548 kB (removed) | π |
dist/606.js |
35.6 kB | +35.6 kB (new file) | π |
dist/639.js |
548 kB | +548 kB (new file) | π |
dist/926.js |
134 kB | +134 kB (new file) | π |
Thanks, everyone!
Requirements
Summary
This PR fixes an issue with the logic that handles deleting questions in the Interactive Builder. Right now, deleting questions is not working as expected. This is because the
pageIndex
,sectionIndex
andquestionIndex
parameters of thedeleteQuestion
function are not being correctly set. (Videos of the current behaviour can be found in the linked issue on Jira)To fix this, I've tweaked the modal logic to register the DeleteQuestion dialog as a modal. That allows us to leverage the modal system to handle creating and disposing of the modal more canonically. I can also pass in the props that the modal requires (
pageIndex
and friends from above) via the modal system.With these changes, the logic is back to working as expected again.
Screenshots
https://github.com/openmrs/openmrs-esm-form-builder/assets/8509731/6cd42dd4-3f29-40c3-a5c4-35a48d35356e
Related Issue
O3-3272
Other