Closed denniskigen closed 1 month ago
Size Change: +16.4 kB (+0.47%)
Total Size: 3.51 MB
@ibacher Any tips on better approaching this issue?
My only suggestion here would be that we apply a class to the ComposedModal
instances so we can scope these style changes to that class, rather than making them global. If that won't work, we should probably move these changes to the styleguide itself so app behaviour remains consistent regardless of whether this app is installed or loaded.
Thanks, @ibacher. Let's see how this goes.
Requirements
Summary
This PR implements a temporary fix for the broken styling of the ComposedModal component's close button. The issue appears to be caused by a version mismatch in the Carbon Design System.
This patch uses scoped global styles to adjust the close button and its tooltip to approximate the intended design. While not an ideal solution, it ensures the component remains functional and visually consistent for now.
The long-term resolution will involve updating Carbon dependencies across the project to align with the latest version. However, this immediate fix addresses the urgent styling break caused by the recent Carbon version upgrade in this repository.
Screenshots
Before
https://github.com/user-attachments/assets/8faa28c2-c1aa-46bd-9c4f-a2efbdb63f3a
After
https://github.com/user-attachments/assets/c00d42df-7935-445d-acc1-72dbcc276cb8
Related Issue
Other