Closed samuelmale closed 3 months ago
Size Change: -248 kB (-19.68%) đ
Total Size: 1.01 MB
Filename | Size | Change | |
---|---|---|---|
dist/371.js |
0 B | -71.5 kB (removed) | đ |
dist/465.js |
0 B | -182 kB (removed) | đ |
dist/998.js |
0 B | -15.6 kB (removed) | đ |
dist/main.js |
343 kB | +42.3 kB (+14.07%) | â ī¸ |
Just tested on dev3 and this fix works as intended! Thanks, @samuelmale.
Requirements
Summary
This PR fixes an issue with the dropdown component re-rendering infinitely on selecting an option in tablet view port. This issue stems from the "downshift" library consumed by Carbon and it seems to be affecting React v18. It was since resolved in downshift
v8.2.4
and carbon.Out of scope
I've also changed Carbon from a peer dependency to a normal dependency.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-3350
Other