openmrs / openmrs-esm-form-engine-lib

React Form Engine library for O3
Other
10 stars 59 forks source link

(fix) O3-3350: Resolve infinite re-rendering of the dropdown component in the tablet viewport #326

Closed samuelmale closed 3 months ago

samuelmale commented 3 months ago

Requirements

Summary

This PR fixes an issue with the dropdown component re-rendering infinitely on selecting an option in tablet view port. This issue stems from the "downshift" library consumed by Carbon and it seems to be affecting React v18. It was since resolved in downshift v8.2.4 and carbon.

Out of scope

I've also changed Carbon from a peer dependency to a normal dependency.

Screenshots

2024-06-18 02-55-53 2024-06-18 02_56_36

Related Issue

https://issues.openmrs.org/browse/O3-3350

Other

github-actions[bot] commented 3 months ago

Size Change: -248 kB (-19.68%) 🎉

Total Size: 1.01 MB

Filename Size Change
dist/371.js 0 B -71.5 kB (removed) 🏆
dist/465.js 0 B -182 kB (removed) 🏆
dist/998.js 0 B -15.6 kB (removed) 🏆
dist/main.js 343 kB +42.3 kB (+14.07%) ⚠ī¸
ℹī¸ View Unchanged | Filename | Size | Change | | | :--- | :---: | :---: | :---: | | `dist/184.js` | 11.2 kB | 0 B | | | `dist/195.js` | 76.6 kB | 0 B | | | `dist/225.js` | 2.57 kB | 0 B | | | `dist/29.js` | 163 kB | 0 B | | | `dist/300.js` | 709 B | 0 B | | | `dist/31.js` | 0 B | -5.32 kB (removed) | 🏆 | | `dist/318.js` | 0 B | -2.43 kB (removed) | 🏆 | | `dist/327.js` | 1.84 kB | 0 B | | | `dist/335.js` | 967 B | 0 B | | | `dist/353.js` | 3.02 kB | 0 B | | | `dist/41.js` | 3.36 kB | 0 B | | | `dist/422.js` | 6.79 kB | 0 B | | | `dist/436.js` | 0 B | -759 B (removed) | 🏆 | | `dist/474.js` | 116 kB | 0 B | | | `dist/491.js` | 9.18 kB | 0 B | | | `dist/540.js` | 2.63 kB | 0 B | | | `dist/55.js` | 756 B | -1.38 kB (-64.67%) | 🏆 | | `dist/635.js` | 14.3 kB | 0 B | | | `dist/70.js` | 482 B | 0 B | | | `dist/776.js` | 3.2 kB | 0 B | | | `dist/8.js` | 0 B | -3.68 kB (removed) | 🏆 | | `dist/800.js` | 245 kB | -49 B (-0.02%) | | | `dist/979.js` | 0 B | -6.85 kB (removed) | 🏆 | | `dist/99.js` | 690 B | 0 B | | | `dist/993.js` | 3.09 kB | 0 B | | | `dist/openmrs-form-engine-lib.js` | 3.72 kB | -48 B (-1.27%) | |

compressed-size-action

denniskigen commented 3 months ago

Just tested on dev3 and this fix works as intended! Thanks, @samuelmale.