(fix) O3-3337 - Support expressions that don't use whitespace as delimiters

[arodidev]

Requirements

• [x] This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• [ ] My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• [x] My work includes tests or is validated by existing tests.

Summary

This PR introduces a fix for various failing expression evaluations due to improper formatting during form construction.

Screenshots

Related Issue

https://openmrs.atlassian.net/browse/O3-3337

Other

[arodidev]

Hi @brandones, the work on this PR had stalled since @pirupius had picked up the issue, albeit using a different approach.

[brandones]

Wait so should we revert this?

When things like that happen, please leave comments on PRs so that people know what's going on.

[samuelmale]

@brandones I would say we revert because this is a half-backed solution. Yes it does the necessary interpolation (further hydrates the expression by updating any lurking referenced field's value path) but it doesn't update the relationships (dependencies) etc. The ideal solution is to properly decompose the expression into parts and we were planning on using a third party library.

[arodidev]

@samuelmale If I’m not mistaken, updating the field dependants was not an area of concern while working on this issue since it was non-problematic. This was to take care of the mis-formatted expressions (ones with irregular whitespace intervals) that was causing the expressions to fail.

[samuelmale]

updating the field dependants was not an area of concern while working on this issue since it was non-problematic.

I would say it is a secondary concern.