openmrs / openmrs-esm-form-engine-lib

React Form Engine library for O3
Other
10 stars 59 forks source link

(fix) O3-3397 Fix tooltips alignment in the form #351

Closed Art-Ndiema closed 2 months ago

Art-Ndiema commented 2 months ago

Requirements

Summary

  1. Tooltip alignment has been fixed,
  2. 8 px margin has been added between the tooltip and the label,
  3. Content-switcher label has been made bold,
  4. The question info for the date picker has been fixed from having the same style as the date picker label,
  5. No more empty tooltip being displayed
  6. The label and the tooltip and the required components have been merged into one file to only allow the tooltip and the required to be displayed when necessary and only show the label when the two are not needed. This fixes the problem of having an empty tooltip next to a label.

Screenshots

Before Merging this PR

  1. image-20240610-130951
  2. Screenshot 2024-07-17 at 11 50 55 AM

    After merging this PR

  3. Screenshot 2024-07-17 at 1 39 30 PM
  4. Screenshot 2024-07-17 at 11 52 59 AM

Related Issue

Here is the Jira Ticket https://openmrs.atlassian.net/browse/O3-3397

Other

@hadijahkyampeire , @arodidev and @CynthiaKamau please review 😊

samuelmale commented 2 months ago

@Art-Ndiema I just pushed a commit with changes that:

  1. Ensure the label isn't duplicated for date-time rendering
  2. Remove redundant styles
  3. More UI refinements

2024-07-26 14-47-23 2024-07-26 14_59_36

CynthiaKamau commented 2 months ago

@samuelmale do you still have any more feedback ?

samuelmale commented 2 months ago

@CynthiaKamau can we resolve this test case?

Art-Ndiema commented 2 months ago

@CynthiaKamau can we resolve this test case?

@samuelmale , the test was addressed from line 252 to 260