openmrs / openmrs-esm-form-engine-lib

React Form Engine library for O3
Other
10 stars 59 forks source link

(fix) O3-3970 Re-enable readonly fields #397

Closed pirupius closed 2 weeks ago

pirupius commented 3 weeks ago

Requirements

Summary

This PR enables readonly mode in the field types that might be having it as well as adding the utility to cater for boolean string values

NOTE: For the date, we're using OpenmrsDatePicker and the readonly still shows the date picker so this might be either in newer versions of the framework or needs to be implemented in esm-core

Screenshots

Text

Screenshot 2024-09-26 at 13 35 25

Multi Select

Screenshot 2024-09-27 at 13 33 27

Number

Screenshot 2024-09-26 at 13 35 37

Radio

Screenshot 2024-09-26 at 13 35 51

Dropdown

Screenshot 2024-09-26 at 13 57 51

Textarea

Screenshot 2024-09-26 at 13 59 13

Toogle

Screenshot 2024-09-26 at 14 03 14

Ui-select extended

Screenshot 2024-09-26 at 14 05 03

Workspace

Screenshot 2024-09-26 at 14 08 00

Related Issue

https://openmrs.atlassian.net/browse/O3-3970

Other

github-actions[bot] commented 3 weeks ago

Size Change: +53 B (0%)

Total Size: 1.15 MB

ℹ️ View Unchanged | Filename | Size | Change | | :--- | :---: | :---: | | `dist/151.js` | 300 kB | 0 B | | `dist/225.js` | 2.57 kB | 0 B | | `dist/277.js` | 1.84 kB | 0 B | | `dist/300.js` | 642 B | 0 B | | `dist/335.js` | 968 B | 0 B | | `dist/353.js` | 3.02 kB | 0 B | | `dist/41.js` | 3.37 kB | 0 B | | `dist/422.js` | 6.8 kB | 0 B | | `dist/501.js` | 108 kB | 0 B | | `dist/540.js` | 2.63 kB | 0 B | | `dist/55.js` | 758 B | 0 B | | `dist/572.js` | 252 kB | +21 B (+0.01%) | | `dist/617.js` | 86.9 kB | 0 B | | `dist/635.js` | 14.3 kB | 0 B | | `dist/70.js` | 483 B | 0 B | | `dist/901.js` | 11.8 kB | 0 B | | `dist/99.js` | 691 B | 0 B | | `dist/993.js` | 3.09 kB | 0 B | | `dist/main.js` | 342 kB | +32 B (+0.01%) | | `dist/openmrs-esm-form-engine-lib.js` | 3.67 kB | 0 B |

compressed-size-action

samuelmale commented 3 weeks ago

@pirupius Can you attach screenshots or a demo video or tests cases showing the readonly feat in action for the different renderings.

pirupius commented 2 weeks ago

@samuelmale this is ready