openmrs / openmrs-esm-form-engine-lib

React Form Engine library for O3
Other
10 stars 59 forks source link

(fix) Resolve a bug where a NaN value causes an infinite re-render cycle in the Number input #406

Closed samuelmale closed 1 week ago

samuelmale commented 1 week ago

Requirements

Summary

Carbon's NumberInput misbehaves when passed a NaN value. This PR addresses this issue by resolving NaN values.

Bug in action:

Screenshot 2024-10-03 at 21 55 10

(The number input fails to render because the calculate expression returns a NaN.)

Screenshots

Fixed:

Screenshot 2024-10-03 at 22 00 50

Related Issue

N/A

Other

github-actions[bot] commented 1 week ago

Size Change: +28 B (0%)

Total Size: 1.18 MB

ℹ️ View Unchanged | Filename | Size | Change | | :--- | :---: | :---: | | `dist/151.js` | 330 kB | 0 B | | `dist/225.js` | 2.57 kB | 0 B | | `dist/277.js` | 1.84 kB | 0 B | | `dist/300.js` | 642 B | 0 B | | `dist/335.js` | 968 B | 0 B | | `dist/353.js` | 3.02 kB | 0 B | | `dist/41.js` | 3.37 kB | 0 B | | `dist/422.js` | 6.8 kB | 0 B | | `dist/501.js` | 108 kB | 0 B | | `dist/540.js` | 2.63 kB | 0 B | | `dist/55.js` | 758 B | 0 B | | `dist/572.js` | 252 kB | +12 B (0%) | | `dist/617.js` | 86.9 kB | 0 B | | `dist/635.js` | 14.3 kB | 0 B | | `dist/70.js` | 483 B | 0 B | | `dist/901.js` | 11.8 kB | 0 B | | `dist/99.js` | 691 B | 0 B | | `dist/993.js` | 3.09 kB | 0 B | | `dist/main.js` | 342 kB | +16 B (0%) | | `dist/openmrs-esm-form-engine-lib.js` | 3.67 kB | 0 B |

compressed-size-action