openmrs / openmrs-esm-form-engine-lib

React Form Engine library for O3
Other
10 stars 59 forks source link

(fix) Evaluate calculate expressions after general form field initialization #407

Closed pirupius closed 3 days ago

pirupius commented 1 week ago

Requirements

Summary

This PR ensures that the form engine evaluates calculate expressions after the general form field initialization. This ensures that any referenced fields (in the calculate expression) are initialised prior.

Before:

Screenshot 2024-10-04 at 15 26 36

Applying any logic would default it to 1970 because of the null value

Screenshot 2024-10-04 at 15 26 18

After:

Screenshot 2024-10-04 at 15 26 56 Screenshot 2024-10-04 at 15 24 00

Screenshots

Related Issue

Other

github-actions[bot] commented 1 week ago

Size Change: +38 B (0%)

Total Size: 1.18 MB

ℹ️ View Unchanged | Filename | Size | Change | | :--- | :---: | :---: | | `dist/151.js` | 330 kB | 0 B | | `dist/225.js` | 2.57 kB | 0 B | | `dist/277.js` | 1.84 kB | 0 B | | `dist/300.js` | 642 B | 0 B | | `dist/335.js` | 968 B | 0 B | | `dist/353.js` | 3.02 kB | 0 B | | `dist/41.js` | 3.37 kB | 0 B | | `dist/420.js` | 108 kB | 0 B | | `dist/422.js` | 6.8 kB | 0 B | | `dist/514.js` | 253 kB | +38 B (+0.02%) | | `dist/540.js` | 2.63 kB | 0 B | | `dist/55.js` | 758 B | 0 B | | `dist/617.js` | 86.9 kB | 0 B | | `dist/635.js` | 14.3 kB | 0 B | | `dist/70.js` | 483 B | 0 B | | `dist/901.js` | 11.8 kB | 0 B | | `dist/99.js` | 691 B | 0 B | | `dist/993.js` | 3.09 kB | 0 B | | `dist/main.js` | 342 kB | 0 B | | `dist/openmrs-esm-form-engine-lib.js` | 3.67 kB | 0 B |

compressed-size-action