(BREAKING) Adopt OpenMRS' global Expression Runner

samuelmale commented 4 days ago

Requirements

[X] This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
[ ] My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
[X] My work includes tests or is validated by existing tests.

Summary

Migrates away from using the custom expression runner that had compilation issues to using OpenMRS' new expression runner which is a safer option. This change should fix most, if not all, of the expression compilation-related issues.

Potential breaking changes:

Async Expressions Previously, the syntax allowed for expressions like "resolve(getAsyncValue()) > someOtherField", which returned a Promise that resolved to a boolean value. The resolve() function was used to handle asynchronous fragments within the expression. Now, the expression runner supports the Promise and then pattern directly. To achieve similar functionality, you must now use syntax like "getAsyncValue().then(value => value > someOtherField)".
Variable Argument Handling
OpenMRS' global expression evaluator only supports variable arguments; it doesn't attempt inferring string arguments. Previously, you could call a function like calcMonthsOnART('artStartDate'), where the string 'artStartDate' would be resolved into a variable if a corresponding field ID existed. This meant that the engine would interpret the string as a reference to an actual variable. With the new expression evaluator, you are expected to use variable arguments: calcMonthsOnART(artStartDate)

Screenshots

Related Issue

github-actions[bot] commented 4 days ago

Size Change: -205 kB (-14.38%) 👏

Total Size: 1.22 MB

Filename	Size	Change
`dist/151.js`	378 kB	+48.2 kB (+14.62%)	⚠️
`dist/514.js`	0 B	-253 kB (removed)	🏆

ℹ️ View Unchanged

| Filename | Size | Change | | :--- | :---: | :---: | | `dist/225.js` | 2.57 kB | 0 B | | `dist/277.js` | 1.84 kB | 0 B | | `dist/300.js` | 642 B | 0 B | | `dist/335.js` | 968 B | 0 B | | `dist/353.js` | 3.02 kB | 0 B | | `dist/41.js` | 3.37 kB | 0 B | | `dist/420.js` | 108 kB | 0 B | | `dist/422.js` | 6.8 kB | 0 B | | `dist/540.js` | 2.63 kB | 0 B | | `dist/55.js` | 758 B | 0 B | | `dist/617.js` | 86.9 kB | 0 B | | `dist/635.js` | 14.3 kB | 0 B | | `dist/70.js` | 483 B | 0 B | | `dist/751.js` | 252 kB | 0 B | | `dist/901.js` | 11.8 kB | 0 B | | `dist/99.js` | 691 B | 0 B | | `dist/993.js` | 3.09 kB | 0 B | | `dist/main.js` | 342 kB | -759 B (-0.22%) | | `dist/openmrs-esm-form-engine-lib.js` | 3.67 kB | +1 B (+0.03%) |

_{compressed-size-action}

samuelmale commented 4 days ago

FYI @michaelbontyes @gracepotma

denniskigen commented 4 days ago

FYI @jnsereko

openmrs / openmrs-esm-form-engine-lib