(feat) Add filters to stock operations table

openmrs / openmrs-esm-stock-management

Other

3 stars 24 forks source link

(feat) Add filters to stock operations table #117

Closed kajambiya closed 4 months ago

kajambiya commented 4 months ago

Requirements

[ ] This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

[ ] My work conforms to the OpenMRS 3.0 Styleguide and design documentation.

If applicable

[ ] My work includes tests or is validated by existing tests.

Summary

This PR adds filters to the stock operations table.

Screenshots

https://github.com/openmrs/openmrs-esm-stock-management/assets/12844964/56eed0d7-ee64-4ef1-aabe-44fd68ad80f6

Related Issue

Other

makombe commented 4 months ago

Thanks @kajambiya LGTM!. One observation from the video, can we make the item list name from the drop down to be visible? Seems when you open the dropdown the text are truncated. The dropdown should be responsive, they should be visible at a glance without the user struggling to read. Thanks

kajambiya commented 4 months ago

Thanks @kajambiya LGTM!. One observation from the video, can we make the item list name from the drop down to be visible? Seems when you open the dropdown the text are truncated. The dropdown should be responsive, they should be visible at a glance without the user struggling to read. Thanks

Thanks @makombe, yah as mentioned in the summary, I'm still fixing some stylings. Just needed folks to review the logic so that after fixing the styles, the PR can move from draft to actual.

kajambiya commented 4 months ago

@makombe & @jabahum I've fixed the styles and other failing logic. Please review and revert

jabahum commented 4 months ago

Thanks @kajambiya. The pagination seems not to be working as expected. I have shared a video below

https://github.com/openmrs/openmrs-esm-stock-management/assets/24471994/64e6703f-0fe0-4a4d-b1cd-e91526d268f1

kajambiya commented 4 months ago

Thanks @kajambiya. The pagination seems not to be working as expected. I have shared a video below

Screen.Recording.2024-02-21.at.08.48.40.mov

Nice catch man. Let me fix it ASAP

kajambiya commented 4 months ago

Thanks @kajambiya. The pagination seems not to be working as expected. I have shared a video below

Screen.Recording.2024-02-21.at.08.48.40.mov

@jabahum the pagination issue has been fixed. Please review and revert.

jabahum commented 4 months ago

@kajambiya Thanks LGTM