search

openmrs / openmrs-esm-stock-management

Other
3 stars 24 forks source link

(O3-3310) : On deleting a packaging unit, an error is thrown rather than a popup dialogue to add a reason for deleting the packaging unit #139

Closed Daphne210 closed 1 month ago

Daphne210 commented 1 month ago

https://github.com/openmrs/openmrs-esm-stock-management/assets/89844768/b84a3525-ada9-4e20-86d5-9af4f2ad74b4

jabahum commented 1 month ago

@Daphne210 thanks. What happens when the yes button on the dialog is clicked

Daphne210 commented 1 month ago

@Daphne210 thanks. What happens when the yes button on the dialog is clicked

https://github.com/openmrs/openmrs-esm-stock-management/assets/89844768/39602b5e-1dc4-49fb-8c17-628e274ebaf5

same error from 2.x as seen in the attached file

jabahum commented 1 month ago

@Daphne210 thanks. What happens when the yes button on the dialog is clicked

20240524174042.mp4 same error from 2.x as seen in the attached file

@slubwama can kindly help fix this issue when deleting packaging units and this is also happening when deleting references items both on 2.x and 03

makombe commented 1 month ago

This is a backend error. There is a stray bracket on the query making it to fail. I remember fixing this locally on our end. Let me make that PR @jabahum

jabahum commented 1 month ago

This is a backend error. There is a stray bracket on the query making it to fail. I remember fixing this locally on our end. Let me make that PR @jabahum

Thanks @makombe

makombe commented 1 month ago

@jabahum This has be addressed through this PR here

jabahum commented 1 month ago

@jabahum This has be addressed through this PR here

Thanks @makombe