(Fix) 03-3450: Delete modal not closing and package units not refreshing after deleting.

hadijahkyampeire commented 2 weeks ago

Requirements

[x] This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

[ ] My work conforms to the OpenMRS 3.0 Styleguide and design documentation.

If applicable

[ ] My work includes tests or is validated by existing tests.

Summary

Add combox placeholder
Close the delete module after delete
Refresh the packingUnits after deleting

Screenshots

https://github.com/openmrs/openmrs-esm-stock-management/assets/30952856/d188a7d0-136b-4e13-a2c4-35d460f0f4a0

Related Issue

https://openmrs.atlassian.net/browse/O3-3450

ojwanganto commented 2 weeks ago

Thanks, @hadijahkyampeire. I wanted to confirm if this 'delete' ideally means voiding and not purging. This is to help preserve the integrity of any references to it. Thanks

hadijahkyampeire commented 2 weeks ago

@ojwanganto I think that would be a question for a backend dev maybe @slubwama, but on the frontend I can not tell whether it is a permanent delete or void, all I know is that we have an endpoint that deletes and that packaging unit disappears from the list of packaging units.

openmrs / openmrs-esm-stock-management