openmrs / openmrs-esm-stock-management

Other
3 stars 25 forks source link

User/Role fields are not selectable. #92

Closed jabahum closed 5 months ago

jabahum commented 5 months ago

Requirements

For changes to apps

If applicable

Summary

Screenshots

https://github.com/METS-Programme/esm-ugandaemr-stock-management/assets/24471994/00345026-ee55-4476-a080-e080a839bbec

updated video

https://github.com/METS-Programme/esm-ugandaemr-stock-management/assets/24471994/f7d416fb-f96c-4b2d-9895-9bee8e77c641

Related Issue

https://metsprogramme.atlassian.net/browse/U4X-276 https://metsprogramme.atlassian.net/browse/U4X-270

Other

makombe commented 5 months ago

@jabahum not sure if I understand what the fix is about. Currently, the user roles get selected well. I think this had been fixed. Can you confirm with the main branch if it is not working has expected, maybe you are still using an outdated branch or the PR title not reflecting what you are fixing. Thanks

jabahum commented 5 months ago

@jabahum not sure if I understand what the fix is about. Currently, the user roles get selected well. I think this had been fixed. Can you confirm with the main branch if it is not working has expected, maybe you are still using an outdated branch or the PR title not reflecting what you are fixing. Thanks

i actually created the branch from the upstream which had the latest changes

jabahum commented 5 months ago

@jabahum not sure if I understand what the fix is about. Currently, the user roles get selected well. I think this had been fixed. Can you confirm with the main branch if it is not working has expected, maybe you are still using an outdated branch or the PR title not reflecting what you are fixing. Thanks

i actually created the branch from the upstream which had the latest changes

and also the fix helps you select only roles defined to a certain user. Thats y u see when a user is selected , other roles display